sgilmore10 commented on code in PR #35918:
URL: https://github.com/apache/arrow/pull/35918#discussion_r1219627839
##########
matlab/src/cpp/arrow/matlab/array/proxy/numeric_array.h:
##########
@@ -42,52 +43,63 @@ const uint8_t* getUnpackedValidityBitmap(const
::matlab::data::TypedArray<bool>&
template<typename CType>
class NumericArray : public arrow::matlab::array::proxy::Array {
public:
- NumericArray(const libmexclass::proxy::FunctionArguments&
constructor_arguments)
- : arrow::matlab::array::proxy::Array(constructor_arguments) {
- using ArrowType = typename arrow::CTypeTraits<CType>::ArrowType;
- using BuilderType = typename
arrow::CTypeTraits<CType>::BuilderType;
+ NumericArray(const std::shared_ptr<arrow::Array> numeric_array)
+ : arrow::matlab::array::proxy::Array() {
+ array = numeric_array;
+ }
- // Get the mxArray from constructor arguments
- const ::matlab::data::TypedArray<CType> numeric_mda =
constructor_arguments[0];
- const ::matlab::data::TypedArray<bool> make_copy =
constructor_arguments[1];
+
+ static libmexclass::proxy::MakeResult make(const
libmexclass::proxy::FunctionArguments& constructor_arguments)
Review Comment:
Good catch. I'll fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
