spenczar commented on code in PR #35865:
URL: https://github.com/apache/arrow/pull/35865#discussion_r1220034053


##########
python/pyarrow/array.pxi:
##########
@@ -2053,6 +2053,38 @@ cdef class ListArray(BaseListArray):
 
     @property
     def values(self):
+        """
+        Return the underlying array of values which backs the ListArray.
+
+        This is logically a concatenation of all the sub-lists in this array.

Review Comment:
   Personally, I find it useful to know the "dimensionality" of this object - 
that it's a flat structure, and it feels like a concatenation of all the 
sub-lists. What do you think of taking out the "logically" qualifier?
   
   Or we could just drop it. The example is pretty clear.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to