amoeba commented on code in PR #35398:
URL: https://github.com/apache/arrow/pull/35398#discussion_r1220708815
##########
r/R/filesystem.R:
##########
@@ -384,7 +387,24 @@ S3FileSystem <- R6Class("S3FileSystem",
region = function() fs___S3FileSystem__region(self)
)
)
-S3FileSystem$create <- function(anonymous = FALSE, ...) {
+S3FileSystem$create <- function(
+ anonymous = FALSE,
+ log_level = c("fatal", "error", "warn", "info", "debug", "trace", "off"),
+ ...) {
+ # Init S3 now only if log_level is set
+ # TODO: This is clunky
Review Comment:
No worries at all. A stand-alone `s3_initialize` was how I did my first
version of this PR but the discussion lead us down putting the functionality
inside `S3FileSystem$create`. `options()` was also suggested before and is
pretty good but has one downside, described in
https://github.com/apache/arrow/pull/35398#issuecomment-1533867236. Maybe the
downside I describe there is acceptable and we just document it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
