davidhcoe commented on code in PR #697:
URL: https://github.com/apache/arrow-adbc/pull/697#discussion_r1220836901


##########
csharp/test/Apache.Arrow.Adbc.FlightSql.Tests/ConnectionTests.cs:
##########
@@ -0,0 +1,138 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements.  See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License.  You may obtain a copy of the License at
+*
+*    http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Text.Json;
+using Apache.Arrow.Adbc.Core;
+using Apache.Arrow.Adbc.Tests;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Moq;
+
+namespace Apache.Arrow.Adbc.FlightSql.Tests
+{
+    /// <summary>
+    /// Abstract class for the ADBC connection tests.
+    /// </summary>
+    [TestClass]
+    public class ConnectionTests
+    {
+        /// <summary>
+        /// Validates if the driver behaves as it should with missing values 
and parsing mock results.
+        /// </summary>
+        [TestMethod]
+        public void CanMockDriverConnect()
+        {
+            Mock<FlightSqlStatement> mockFlightSqlStatement = 
GetMockSqlStatement();
+
+            FlightSqlDatabase db = new FlightSqlDatabase(new 
Dictionary<string, string>());
+
+            Assert.ThrowsException<ArgumentNullException>(() => 
db.Connect(null));
+
+            Assert.ThrowsException<ArgumentException>(() => db.Connect(new 
Dictionary<string, string>()));
+
+            QueryResult queryResult = 
mockFlightSqlStatement.Object.ExecuteQuery();
+
+            Adbc.Tests.ConnectionTests.CanDriverConnect(queryResult, 50);
+        }
+
+        /// <summary>
+        /// Validates if the driver can connect to a live server and parse the 
results.
+        /// </summary>
+        [TestMethod]
+        public void CanDriverConnect()
+        {
+            FlightSqlTestConfiguration flightSqlTestConfiguration = 
GetFlightSqlTestConfiguration();
+
+            Dictionary<string, string> parameters = new Dictionary<string, 
string>
+            {
+                { FlightSqlParameters.ServerAddress, 
flightSqlTestConfiguration.ServerAddress },
+                { FlightSqlParameters.RoutingTag, 
flightSqlTestConfiguration.RoutingTag },
+                { FlightSqlParameters.RoutingQueue, 
flightSqlTestConfiguration.RoutingQueue },
+                { FlightSqlParameters.Authorization, 
flightSqlTestConfiguration.Authorization}
+            };
+
+            Dictionary<string, string> options = new Dictionary<string, 
string>()
+            {
+                { FlightSqlParameters.ServerAddress, 
flightSqlTestConfiguration.ServerAddress },
+            };
+
+            FlightSqlDriver flightSqlDriver = new FlightSqlDriver();
+            FlightSqlDatabase flightSqlDatabase = 
flightSqlDriver.Open(parameters) as FlightSqlDatabase;
+            FlightSqlConnection connection = 
flightSqlDatabase.Connect(options) as FlightSqlConnection;
+            FlightSqlStatement statement = connection.CreateStatement() as 
FlightSqlStatement;
+
+            statement.SqlQuery = flightSqlTestConfiguration.Query;
+            QueryResult queryResult = statement.ExecuteQuery();
+
+            Adbc.Tests.ConnectionTests.CanDriverConnect(queryResult, 
flightSqlTestConfiguration.ExpectedResultsCount);
+        }
+        /// <summary>

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to