joemarshall commented on code in PR #35672:
URL: https://github.com/apache/arrow/pull/35672#discussion_r1220899262
##########
cpp/src/arrow/util/thread_pool.cc:
##########
@@ -183,6 +247,105 @@ void SerialExecutor::RunLoop() {
}
state_->current_thread = {};
}
+#else // ARROW_ENABLE_THREADING
+bool SerialExecutor::RunTasksOnAllExecutors(bool once_only) {
Review Comment:
I think pretty much anything that does I/O assumes that the i/o calls and
serialexecutor calls run in parallel. Without this stuff, serialexecutors can't
run at the same time as I/O things which breaks quite a lot of things including
loading parquet files. Executors need to be able to assume that other things
will happen if they don't have any tasks ready to run or else bad things happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
