lidavidm commented on issue #734:
URL: https://github.com/apache/arrow-adbc/issues/734#issuecomment-1580795228
```c
sqlite3_mutex_enter(sqlite3_db_mutex(reader->db));
while (batch_size < reader->batch_size) {
if (reader->binder) {
char finished = 0;
struct AdbcError error = {0};
AdbcStatusCode status = AdbcSqliteBinderBindNext(reader->binder,
reader->db,
reader->stmt,
&finished, &error);
if (status != ADBC_STATUS_OK) {
reader->done = 1;
status = EIO;
if (error.release) {
strncpy(reader->error.message, error.message,
sizeof(reader->error.message));
reader->error.message[sizeof(reader->error.message) - 1] = '\0';
error.release(&error);
}
break;
} else if (finished) {
reader->done = 1;
break;
}
}
int rc = sqlite3_step(reader->stmt);
```
I think there's a mistake here; we shouldn't bind until we exhaust the
current stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
