Ulimo commented on a change in pull request #8902:
URL: https://github.com/apache/arrow/pull/8902#discussion_r543268834
##########
File path: csharp/src/Apache.Arrow/Field.cs
##########
@@ -34,6 +35,22 @@ public partial class Field
public Field(string name, IArrowType dataType, bool nullable,
IEnumerable<KeyValuePair<string, string>> metadata = default)
+ : this(name, dataType, nullable)
+ {
+ Metadata = metadata?.ToDictionary(kv => kv.Key, kv => kv.Value);
+
+ }
+
+ internal Field(string name, IArrowType dataType, bool nullable,
+ IReadOnlyDictionary<string, string> metadata, bool copyCollections)
Review comment:
Ah, I completely missed that they were of different types. Makes sense,
thanks for the explanation!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]