candiduslynx commented on code in PR #35983:
URL: https://github.com/apache/arrow/pull/35983#discussion_r1222024655
##########
go/arrow/compute/exprs/types.go:
##########
@@ -623,7 +623,7 @@ func ToSubstraitType(dt arrow.DataType, nullable bool, ext
ExtensionIDSet) (type
if err != nil {
return nil, err
}
- valueType, err := ToSubstraitType(dt.ValueType(),
dt.ValueField().Nullable, ext)
+ valueType, err := ToSubstraitType(dt.Elem(),
dt.ElemField().Nullable, ext)
Review Comment:
This is wrong, as the value here is a value in `key-value pair` sense, so it
has to be `Item` in `arrow.MapType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
