icexelloss commented on code in PR #35874:
URL: https://github.com/apache/arrow/pull/35874#discussion_r1222189098
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -529,7 +529,7 @@ class KeyHasher {
size_t index_;
std::vector<col_index_t> indices_;
std::vector<KeyColumnMetadata> metadata_;
- const RecordBatch* batch_;
+ std::atomic<const RecordBatch*> batch_;
Review Comment:
I see in that case you can update the doc to explain how this class should
be used in multi-threaded execution? Currently looks like the doc about thread
safety is not correct, i.e., it is used by multiple thread while the docstring
says it's not thread safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
