comphead commented on code in PR #6591: URL: https://github.com/apache/arrow-datafusion/pull/6591#discussion_r1222320474
########## datafusion/core/tests/sqllogictests/test_files/scalar.slt: ########## @@ -911,15 +911,15 @@ SELECT not(true), not(false) ---- false true -query BB -SELECT not(1), not(0) ----- --2 -1 - query ?B SELECT null, not(null) ---- -NULL NULL +NULL true + +query B Review Comment: these cases are worth to be tested as well ``` SELECT not(null) is (not) distinct from null SELECT not(null) is (not) null select not(a) from (SELECT null a union all select 1) x ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
