jackwener commented on code in PR #6595:
URL: https://github.com/apache/arrow-datafusion/pull/6595#discussion_r1222650406
##########
datafusion/expr/src/utils.rs:
##########
@@ -730,13 +730,10 @@ pub fn from_plan(
inputs: &[LogicalPlan],
) -> Result<LogicalPlan> {
match plan {
- LogicalPlan::Projection(Projection { schema, .. }) => {
- Ok(LogicalPlan::Projection(Projection::try_new_with_schema(
- expr.to_vec(),
- Arc::new(inputs[0].clone()),
- schema.clone(),
- )?))
- }
Review Comment:
Here exist a bug, we shouldn't use original `schema`, because it can be
changed.
Original code hidden some BUG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
