jorisvandenbossche commented on PR #702: URL: https://github.com/apache/arrow-adbc/pull/702#issuecomment-1582850472
Yes, but so currently both the sqlite and postgresql driver crash when consuming a stream from a closed transaction (I can take a look at fixing that, though). If we say it's the driver's responsibility to error for this, is there still any value in the "wrapped array stream" that keeps a reference to the Python AdbcStatement object? I assume that the original ArrowArrayStream references the C transaction/connection (or TupleReader in the postgres driver), and there is not necessarily a need to explicitly track the python object? Or is that still needed to also keep the C object alive? (from a quick experiment letting the postgres-produced stream raise if the statement was released, this doesn't seem needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
