icexelloss commented on code in PR #35514:
URL: https://github.com/apache/arrow/pull/35514#discussion_r1223409885
##########
python/pyarrow/src/arrow/python/udf.cc:
##########
@@ -101,6 +125,103 @@ struct PythonTableUdfKernelInit {
UdfWrapperCallback cb;
};
+struct PythonUdfScalarAggregatorImpl : public ScalarUdfAggregator {
+ PythonUdfScalarAggregatorImpl(UdfWrapperCallback agg_cb,
+ std::shared_ptr<OwnedRefNoGIL> agg_function,
+ std::vector<std::shared_ptr<DataType>>
input_types,
+ std::shared_ptr<DataType> output_type)
+ : agg_cb(agg_cb), agg_function(agg_function), output_type(output_type) {
+ Py_INCREF(agg_function->obj());
Review Comment:
Admitted there could be some redundancy here. I created an follow up to take
a closer look:
https://github.com/apache/arrow/issues/36000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
