alamb opened a new pull request, #6612: URL: https://github.com/apache/arrow-datafusion/pull/6612
# Which issue does this PR close? N/A (though inspired by #5781 ) # Rationale for this change This has been a pet peeve of mine and I think it makes working with this code harder than needed as finding important functionality like "what is the signature of this function" harder because they aren't documented on https://docs.rs/datafusion-expr/26.0.0/datafusion_expr/enum.BuiltinScalarFunction.html # What changes are included in this PR? 1. Move `signature`, `return_type` and `generate_signature_error_msg` to functions on `BuiltinScalarFunction` 2. Mark the existing functions as deprecated # Are these changes tested? existing coverage <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? Hopefully easier to navigate code <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
