paleolimbot commented on code in PR #35955:
URL: https://github.com/apache/arrow/pull/35955#discussion_r1224240655
##########
r/tests/testthat/test-dataset-csv.R:
##########
@@ -574,3 +574,11 @@ test_that("open_delim_dataset params passed through to
open_dataset", {
expect_equal(ds$time, "16-01-2023")
})
+
Review Comment:
One more test here for the data access part (as opposed to the printing
part)? Like:
```r
test_that("CSV options field access", {
options <- CsvReadOptions$create(skip_rows = 102)
expect_identical(options$skip_rows, 102)
# ... for all the options we just added the ability to access
})
```
...for each option we added a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
