lidavidm commented on code in PR #221:
URL: https://github.com/apache/arrow-nanoarrow/pull/221#discussion_r1224374953
##########
src/nanoarrow/array.c:
##########
@@ -168,21 +168,40 @@ ArrowErrorCode ArrowArrayInitFromType(struct ArrowArray*
array,
ArrowErrorCode ArrowArrayInitFromArrayView(struct ArrowArray* array,
struct ArrowArrayView* array_view,
struct ArrowError* error) {
- ArrowArrayInitFromType(array, array_view->storage_type);
+ NANOARROW_RETURN_NOT_OK_WITH_ERROR(
+ ArrowArrayInitFromType(array, array_view->storage_type), error);
Review Comment:
Seems like you could guard against forgetting with `-Wunused-result` and
manually annotating functions with the (compiler specific)
`__attribute__((warn_unused_result))` though that is rather a hassle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
