alamb commented on code in PR #6621:
URL: https://github.com/apache/arrow-datafusion/pull/6621#discussion_r1224777480
##########
datafusion/physical-expr/src/window/partition_evaluator.rs:
##########
@@ -127,13 +117,16 @@ pub trait PartitionEvaluator: Debug + Send {
Ok(())
}
- /// Sets the internal state for window function
+ /// When the window frame has a fixed beginning (e.g UNBOUNDED
Review Comment:
While writing this explanation it occurred to me that the term `memoize`,
while technically accurate is not the entire story here. I wonder if there is a
better name like `adjust_window_state` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
