alamb commented on code in PR #6624:
URL: https://github.com/apache/arrow-datafusion/pull/6624#discussion_r1225797870
##########
datafusion/expr/src/function.rs:
##########
@@ -185,14 +188,14 @@ pub fn return_type(
"The {fun} function can only accept list as the first argument"
))),
},
- BuiltinScalarFunction::Cardinality => Ok(DataType::UInt64),
- BuiltinScalarFunction::MakeArray =>
Ok(DataType::List(Arc::new(Field::new(
+ BuiltinScalarFunction::Cardinality => Ok(UInt64),
Review Comment:
This is a nice change, but will conflict with
https://github.com/apache/arrow-datafusion/pull/6612
(which is fine, I can handle resolving it, but perhaps you have some time to
review https://github.com/apache/arrow-datafusion/pull/6612 @jackwener to
minimize future conflicts)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
