domoritz commented on code in PR #35780:
URL: https://github.com/apache/arrow/pull/35780#discussion_r1225872793
##########
js/src/builder.ts:
##########
@@ -289,7 +290,7 @@ export abstract class Builder<T extends DataType = any,
TNull = any> {
valueOffsets = _offsets?.flush(length);
} else if (valueOffsets = _offsets?.flush(length)) { // Variable-width
primitives (Binary, Utf8), and Lists
// Binary, Utf8
- data = _values?.flush(_offsets.last());
+ data = _values?.flush(Number(_offsets.last()));
Review Comment:
I think this will fail for very large offsets that are larger than `number`
allows but I think that's inevitable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
