mustafasrepo commented on code in PR #6619:
URL: https://github.com/apache/arrow-datafusion/pull/6619#discussion_r1226205915
##########
datafusion/physical-expr/src/window/row_number.rs:
##########
@@ -61,6 +58,24 @@ impl BuiltInWindowFunctionExpr for RowNumber {
&self.name
}
+ fn add_equal_orderings(&self, builder: &mut OrderingEquivalenceBuilder) {
+ // Only the built-in `RowNumber` window function introduces a new
Review Comment:
Maybe we can replace comment
`// Only the built-in RowNumber window function introduces a new` with
`// The built-in RowNumber window function introduces a new`. Since method
implements it (and special handling is not done outside), we do not need stress
this is the only window function with this property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
