jorgecarleitao commented on pull request #8901: URL: https://github.com/apache/arrow/pull/8901#issuecomment-745791950
Thanks all for the suggestions. Really good stuff. I have incorporated all the changes: * the change of the requirement for performance was re-written as suggested by @alamb and @Dandandan * added a code snipped with the idea from @andygrove * fixed typos identified by @paddyhoran I have used the term `soundness` instead of `correctness` because the former is already defined on an official guide: https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library and is based on existing literature, while the latter seems to be used only by imageproc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
