viirya commented on code in PR #6232:
URL: https://github.com/apache/arrow-datafusion/pull/6232#discussion_r1227070238
##########
datafusion/physical-expr/src/math_expressions.rs:
##########
@@ -287,6 +288,16 @@ pub fn random(args: &[ColumnarValue]) ->
Result<ColumnarValue> {
Ok(ColumnarValue::Array(Arc::new(array)))
}
+macro_rules! round_downcast_decimal_places {
+ ($dp:expr) => {
+ $dp.try_into().map_err(|_| {
+ DataFusionError::Execution(
+ "round function requires decimal_places as 32 bit
integers".to_string(),
+ )
+ })
+ };
+}
+
Review Comment:
You can have a inline function instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
