quinnj commented on code in PR #464: URL: https://github.com/apache/arrow-julia/pull/464#discussion_r1227155653
########## src/FlatBuffers/builder.jl: ########## @@ -63,8 +71,8 @@ end Base.write(sink::Builder, o, x::Union{Bool,UInt8}) = sink.bytes[o+1] = UInt8(x) function Base.write(sink::Builder, off, x::T) where {T} off += 1 - for (i, ind) = enumerate(off:(off + sizeof(T) - 1)) - sink.bytes[ind] = (x >> ((i-1) * 8)) % UInt8 + for (i, ind) in enumerate(off:(off+sizeof(T)-1)) + sink.bytes[ind] = (x >> ((i - 1) * 8)) % UInt8 Review Comment: What the? what's the rule here? it seems to usually take away spaces in the 1st line, but _adds_ them in the 2nd? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org