westonpace commented on issue #35957: URL: https://github.com/apache/arrow/issues/35957#issuecomment-1589402007
Yes, that would be great (though we'll want to add at least one test case too). Looking in more detail it seems that `is_temporal` might miss the interval types (I had thought intervals were temporal). I think we can do some basic arithmetic on intervals. So we could add `is_interval` but then it gets very cluttered. I wonder if we might just want to add a new type test `is_arithmetic` in type_traits.h. Another option we could do is to use `is_primitive` which looks like it ends up being the same list except it also includes `boolean` which we don't support for arithmetic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
