lidavidm commented on code in PR #35314:
URL: https://github.com/apache/arrow/pull/35314#discussion_r1228543844
##########
java/memory/memory-netty/src/test/java/org/apache/arrow/memory/TestBaseAllocator.java:
##########
@@ -1091,6 +1097,40 @@ public void testMemoryLeakWithReservation() throws
Exception {
}
}
+ @Test
+ public void testMemoryUsage() {
+ ListAppender<ILoggingEvent> memoryLogsAppender = new ListAppender<>();
+ Logger logger = (Logger) LoggerFactory.getLogger("arrow.allocator");
+ try {
+ logger.setLevel(Level.TRACE);
+ logger.addAppender(memoryLogsAppender);
+ memoryLogsAppender.start();
+ try (ArrowBuf buf = new ArrowBuf(ReferenceManager.NO_OP, null,
+ 1024, new PooledByteBufAllocatorL().empty.memoryAddress())) {
+ buf.memoryAddress();
+ }
+ boolean result = false;
+ long startTime = System.currentTimeMillis();
+ while (true) {
+ result = memoryLogsAppender.list.stream()
+ .anyMatch(
+ log -> log.toString().contains("Memory Usage: \n") &&
+ log.toString().contains("Large buffers outstanding: ") &&
+ log.toString().contains("Normal buffers outstanding: ") &&
+ log.getLevel().equals(Level.TRACE)
+ );
+ if (result || (System.currentTimeMillis() - startTime) > 10000) { //
10 seconds maximum for time to write logs
Review Comment:
you could just make this the loop guard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
