kou commented on issue #36025:
URL: https://github.com/apache/arrow/issues/36025#issuecomment-1590215101
I see.
Can you update our `dev/release/verify-release-candidate.sh` to require
Node.js 16.* or 18.14+ something like this?
```diff
diff --git a/dev/release/verify-release-candidate.sh
b/dev/release/verify-release-candidate.sh
index 4183520a0..8aeb0f6b5 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -315,22 +315,22 @@ install_nodejs() {
return 0
fi
- required_node_major_version=16
node_major_version=$(node --version 2>&1 | grep -o '^v[0-9]*' | sed -e
's/^v//g' || :)
-
- if [ -n "${node_major_version}" ] && [ "${node_major_version}" -ge
${required_node_major_version} ]; then
- show_info "Found NodeJS installation with major version
${node_major_version}"
+ node_minor_version=$(node --version 2>&1 | grep -o '^v[0-9]*\.[0-9]*' |
sed -e 's/^v[0-9]*\.//g' || :)
+ if [ -n "${node_major_version}" ] && [ -n "${node_minor_version}" ] && \
+ { [ "${node_major_version}" -eq 16 ] || \
+ { [ "${node_major_version}" -eq 18 ] && [
"${node_minor_version}" -ge 14 ] } || \
+ [ "${node_major_version}" -ge 20 ] }; then
+ show_info "Found Node.js installation with major version
${node_major_version}.${node_minor_version}"
else
- export NVM_DIR="`pwd`/.nvm"
+ export NVM_DIR="$(pwd)/.nvm"
mkdir -p $NVM_DIR
curl -sL
https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh | \
PROFILE=/dev/null bash
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
- # ARROW-18335: "gulp bundle" failed with Node.js 18.
- # nvm install --lts
- nvm install 16
- show_info "Installed NodeJS $(node --version)"
+ nvm install --lts
+ show_info "Installed Node.js $(node --version)"
fi
NODEJS_ALREADY_INSTALLED=1
@@ -837,7 +837,7 @@ test_js() {
show_header "Build and test JavaScript libraries"
maybe_setup_nodejs || exit 1
- maybe_setup_conda nodejs=16 || exit 1
+ maybe_setup_conda nodejs=18 || exit 1
if ! command -v yarn &> /dev/null; then
npm install yarn
```
We can test `dev/release/verify-release-candidate.sh` by `TEST_DEFAULT=0
TEST_JS=1 dev/release/verify-release-candidate.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
