andygrove commented on a change in pull request #8936:
URL: https://github.com/apache/arrow/pull/8936#discussion_r544368023
##########
File path: rust/arrow-flight/src/utils.rs
##########
@@ -113,7 +113,13 @@ pub fn flight_data_to_arrow_batch(
schema: SchemaRef,
) -> Option<Result<RecordBatch>> {
// check that the data_header is a record batch message
- let message = arrow::ipc::get_root_as_message(&data.data_header[..]);
+ let res = arrow::ipc::root_as_message(&data.data_header[..]);
+ if res.is_err() {
Review comment:
Shouldn't we return `Some(Err(_))` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
