mapleFU commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1229596260
##########
cpp/src/parquet/encoding.cc:
##########
@@ -3503,7 +3591,11 @@ std::unique_ptr<Decoder> MakeDictDecoder(Type::type
type_num,
case Type::DOUBLE:
return std::make_unique<DictDecoderImpl<DoubleType>>(descr, pool);
case Type::BYTE_ARRAY:
- return std::make_unique<DictByteArrayDecoderImpl>(descr, pool);
+ if (use_large_binary_variants) {
+ return std::make_unique<DictLargeByteArrayDecoderImpl>(descr, pool);
+ } else {
+ return std::make_unique<DictByteArrayDecoderImpl<>>(descr, pool);
Review Comment:
Ok I guess maybe just `DictByteArrayDecoderImpl<ByteArrayType>` is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
