arthurpassos commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1229597455
##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -462,7 +463,8 @@ class LeafReader : public ColumnReaderImpl {
input_(std::move(input)),
descr_(input_->descr()) {
record_reader_ = RecordReader::Make(
Review Comment:
I honestly do not know all the details & purpose of the modified structures,
I only tried to adapt and create necessary LARGE variants & stuff.
Now that you mentioned the cases of opening a file vs using `RecordReader`,
I think I understand a bit more what you are saying. If I understand correctly,
when reading from a file, if `use_large_binary_variants == true`, it'll simply
use the LARGE* structures and will not have a problem. But in case the user has
a `field`, `record`, `array`, whatever else that is not of type LARGE* but
tries to use large, it'll end up in this situation. Did I get it right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
