nealrichardson commented on a change in pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#discussion_r544456115
##########
File path: .env
##########
@@ -47,3 +47,4 @@ ARROW_R_DEV=TRUE
R_ORG=rhub
R_IMAGE=ubuntu-gcc-release
R_TAG=latest
+DEVTOOLSET_VERSION=-1
Review comment:
This probably deserves a comment to say that the default (negative)
means not to install a devtoolset
##########
File path: ci/scripts/r_docker_configure.sh
##########
@@ -39,6 +39,16 @@ if [ "$RHUB_PLATFORM" = "linux-x86_64-fedora-clang" ]; then
rm -rf $(${R_BIN} RHOME)/etc/Makeconf.bak
fi
+# Special hacking to try to reproduce quirks on centos using non-default build
+# tooling.
+if [[ "$R_TAG" == *centos* && "$DEVTOOLSET_VERSION" > 0 ]]; then
+ if [ "`which dnf`" ]; then
+ dnf install -y "devtoolset-$DEVTOOLSET_VERSION"
+ else [ "`which yum`" ]; then
Review comment:
If we have a devtoolset specified, we want it to install it one way or
another
```suggestion
else
```
##########
File path: ci/scripts/r_docker_configure.sh
##########
@@ -39,6 +39,16 @@ if [ "$RHUB_PLATFORM" = "linux-x86_64-fedora-clang" ]; then
rm -rf $(${R_BIN} RHOME)/etc/Makeconf.bak
fi
+# Special hacking to try to reproduce quirks on centos using non-default build
+# tooling.
+if [[ "$R_TAG" == *centos* && "$DEVTOOLSET_VERSION" > 0 ]]; then
Review comment:
We won't set this except on a centos job, so you probably don't need to
check R_TAG (which I believe isn't defined at this point anyway, this script
gets called in a dockerfile, and R_TAG isn't set in the dockerfile).
```suggestion
if [ "$DEVTOOLSET_VERSION" > 0 ]; then
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
