returnString commented on a change in pull request #8917:
URL: https://github.com/apache/arrow/pull/8917#discussion_r544457191
##########
File path: rust/datafusion/src/datasource/datasource.rs
##########
@@ -48,9 +66,19 @@ pub trait TableProvider {
&self,
projection: &Option<Vec<usize>>,
batch_size: usize,
+ filters: &[Expr],
Review comment:
I think I'll leave this for the moment; on reflection, perhaps it'd be
better to come up with a more future-proof design if we anticipate needing to
expose more info to providers at scan-time; something along the lines of
passing a "ScanArgs" struct rather than separate function args here? (as a
future PR, I mean)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
