kou commented on code in PR #36061:
URL: https://github.com/apache/arrow/pull/36061#discussion_r1230157950
##########
.github/workflows/python.yml:
##########
@@ -47,41 +47,41 @@ jobs:
name: ${{ matrix.title }}
runs-on: ubuntu-latest
if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
- timeout-minutes: 60
+ timeout-minutes: 90
strategy:
fail-fast: false
matrix:
name:
- conda-python-docs
- - conda-python-3.8-nopandas
- - conda-python-3.7-pandas-1.0
- - conda-python-3.9-pandas-latest
+ - conda-python-3.9-nopandas
+ - conda-python-3.8-pandas-1.0
+ - conda-python-3.10-pandas-latest
include:
- name: conda-python-docs
cache: conda-python-3.9
image: conda-python-docs
title: AMD64 Conda Python 3.9 Sphinx & Numpydoc
python: 3.9
- - name: conda-python-3.8-nopandas
- cache: conda-python-3.8
+ - name: conda-python-3.9-nopandas
+ cache: conda-python-3.9
image: conda-python
- title: AMD64 Conda Python 3.8 Without Pandas
- python: 3.8
- - name: conda-python-3.7-pandas-1.0
- cache: conda-python-3.7
+ title: AMD64 Conda Python 3.9 Without Pandas
+ python: 3.9
+ - name: conda-python-3.8-pandas-1.0
+ cache: conda-python-3.8
image: conda-python-pandas
- title: AMD64 Conda Python 3.7 Pandas 1.0
- python: 3.7
+ title: AMD64 Conda Python 3.8 Pandas 1.0
+ python: 3.8
pandas: 1.0
numpy: 1.16
- - name: conda-python-3.9-pandas-latest
- cache: conda-python-3.9
+ - name: conda-python-3.10-pandas-latest
+ cache: conda-python-3.10
image: conda-python-pandas
- title: AMD64 Conda Python 3.9 Pandas latest
- python: 3.9
+ title: AMD64 Conda Python 3.10 Pandas latest
+ python: "3.10"
pandas: latest
env:
- PYTHON: ${{ matrix.python || 3.7 }}
+ PYTHON: ${{ matrix.python || 3.8 }}
UBUNTU: ${{ matrix.ubuntu || 18.04 }}
Review Comment:
We dropped support for Ubuntu 18.04: #33800
```suggestion
UBUNTU: ${{ matrix.ubuntu || 20.04 }}
```
##########
.github/workflows/python.yml:
##########
@@ -47,41 +47,41 @@ jobs:
name: ${{ matrix.title }}
runs-on: ubuntu-latest
if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
- timeout-minutes: 60
+ timeout-minutes: 90
strategy:
fail-fast: false
matrix:
name:
- conda-python-docs
- - conda-python-3.8-nopandas
- - conda-python-3.7-pandas-1.0
- - conda-python-3.9-pandas-latest
+ - conda-python-3.9-nopandas
+ - conda-python-3.8-pandas-1.0
+ - conda-python-3.10-pandas-latest
include:
- name: conda-python-docs
cache: conda-python-3.9
image: conda-python-docs
title: AMD64 Conda Python 3.9 Sphinx & Numpydoc
python: 3.9
- - name: conda-python-3.8-nopandas
- cache: conda-python-3.8
+ - name: conda-python-3.9-nopandas
+ cache: conda-python-3.9
image: conda-python
- title: AMD64 Conda Python 3.8 Without Pandas
- python: 3.8
- - name: conda-python-3.7-pandas-1.0
- cache: conda-python-3.7
+ title: AMD64 Conda Python 3.9 Without Pandas
+ python: 3.9
+ - name: conda-python-3.8-pandas-1.0
+ cache: conda-python-3.8
image: conda-python-pandas
- title: AMD64 Conda Python 3.7 Pandas 1.0
- python: 3.7
+ title: AMD64 Conda Python 3.8 Pandas 1.0
+ python: 3.8
pandas: 1.0
Review Comment:
We may need to use `"1.0"`:
```suggestion
pandas: "1.0"
```
##########
dev/tasks/tasks.yml:
##########
@@ -1517,9 +1516,9 @@ tasks:
image: conda-python-hdfs
{% endfor %}
-{% for python_version, spark_version, test_pyarrow_only, numpy_version in
[("3.7", "v3.1.2", "false", "latest"),
-
("3.8", "v3.2.0", "false", "1.23"),
-
("3.9", "master", "false", "latest")] %}
+{% for python_version, spark_version, test_pyarrow_only, numpy_version in
[("3.8", "v3.1.2", "false", "latest"),
Review Comment:
Do we still need Spark 3.1.2?
I think that Spark 3.1 reached EOL:
https://spark.apache.org/versioning-policy.html
> Feature release branches will, generally, be maintained with bug fix
releases for a period of 18 months.
And 3.1.1 was released on 2021-03-02:
https://spark.apache.org/news/index.html
> [Spark 3.1.1
released](https://spark.apache.org/news/spark-3-1-1-released.html)
>
> March 2, 2021
3.2 might reach EOL because 3.2.0 was released on 2021-10-13:
> [Spark 3.2.0
released](https://spark.apache.org/news/spark-3-2-0-released.html)
>
> October 13, 2021
@kiszk Do you know what Spark versions are maintained?
##########
python/requirements-wheel-test.txt:
##########
@@ -7,8 +7,7 @@ pytest-lazy-fixture
pytz
tzdata; sys_platform == 'win32'
-numpy==1.19.5; platform_system == "Linux" and platform_machine == "aarch64"
and python_version < "3.7"
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64"
and python_version >= "3.7" and python_version < "3.11"
+numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64"
and python_version >= "3.8" and python_version < "3.11"
Review Comment:
```suggestion
numpy==1.21.3; platform_system == "Linux" and platform_machine ==
"aarch64" and python_version < "3.11"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
