pitrou commented on a change in pull request #8939:
URL: https://github.com/apache/arrow/pull/8939#discussion_r544489391
##########
File path: cpp/src/parquet/schema.cc
##########
@@ -550,11 +550,11 @@ std::unique_ptr<Node> Unflatten(const
format::SchemaElement* elements, int lengt
int field_id = current_id++;
const void* opaque_element = static_cast<const void*>(&element);
- if (element.num_children == 0) {
+ if (!element.__isset.num_children) {
Review comment:
Though it seems to produce failures on some Python Parquet tests
(because of legacy files?). Let me see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
