pitrou commented on code in PR #36018:
URL: https://github.com/apache/arrow/pull/36018#discussion_r1231172318
##########
cpp/CMakePresets.json:
##########
@@ -11,6 +11,7 @@
"hidden": true,
"generator": "Ninja",
"cacheVariables": {
+ "CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
Review Comment:
I agree that the generated file is not huge, but I also think these presets
should enable just what's necessary for development. They serve as
documentation and starting points for users. It's easy to enable additional
options on top of an existing preset, AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]