icexelloss commented on code in PR #35874:
URL: https://github.com/apache/arrow/pull/35874#discussion_r1231409358
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -668,18 +663,19 @@ class InputState {
static Result<std::unique_ptr<InputState>> Make(
size_t index, TolType tolerance, bool must_hash, bool may_rehash,
- KeyHasher* key_hasher, ExecNode* node, AsofJoinNode* output,
+ KeyHasher* key_hasher, ExecNode* asof_input, AsofJoinNode* asof_node,
Review Comment:
Not sure I fully understand, but from my understanding both the InputState
and BackpressureController takes two node, one node presents the input table of
asof join, and another is the asof join node itself. So my point here is it's
better to make them consistent naming to avoid confusion. And you seem to say
that InputState and BackpressureController have different perspective of input
and output, which I do not fully get but perhaps I misunderstood what you mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
