jorisvandenbossche commented on code in PR #117:
URL: https://github.com/apache/arrow-nanoarrow/pull/117#discussion_r1231429193
##########
.github/workflows/python.yaml:
##########
@@ -57,3 +57,31 @@ jobs:
- name: Run tests
run: |
pytest python/tests -v -s
+
+ - name: Run doctests
+ if: success() && matrix.python-version == '3.10'
+ run: |
+ # Needs editable install to run --doctest-cython
+ pip install pytest-cython
+ pip install -e python
Review Comment:
FWIW, we use this package in Arrow CI with a normal install of pyarrow
(non-editable), so I think it should certainly work. What you might have
noticed locally is that a test didn't pass after updating it if you didn't
re-install it? (that's the reason for locally using editable, so you don't have
to reinstall after every tiny change. But on CI that doesn't matter)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
