alamb opened a new pull request, #6687: URL: https://github.com/apache/arrow-datafusion/pull/6687
# Which issue does this PR close? N/A # Rationale for this change While working on https://github.com/apache/arrow-datafusion/pull/6682 I noticed that the names of some or our integration tests are very confusing. Specifically ```shell cargo test --test error: "--test" takes one argument. Available tests: aggregate_fuzz config_from_env custom_sources dataframe dataframe_functions fifo integration-test <-- these tests differ by 1 character! (this is in the sql crate) integration_test <-- '_' (this is in the optimizer crate) join_fuzz memory_limit merge_fuzz order_spill_fuzz parquet_exec path_partition provider_filter_pushdown repartition roundtrip_logical_plan roundtrip_physical_plan row serialize simplification sql_integration <-- this is in the core crate, not the sql crate sqllogictests statistics tpcds_planning user_defined_aggregates user_defined_plan window_fuzz ``` # What changes are included in this PR? Rename the tests so: ``` Available tests: aggregate_fuzz config_from_env core_integration <-- in the core crate custom_sources dataframe dataframe_functions fifo join_fuzz memory_limit merge_fuzz optimizer_integration <-- in the optimizer crate order_spill_fuzz parquet_exec path_partition provider_filter_pushdown repartition roundtrip_logical_plan roundtrip_physical_plan row serialize simplification sql_integration <-- in the sql crate sqllogictests statistics tpcds_planning user_defined_aggregates user_defined_plan window_fuzz ``` # Are these changes tested? CI runs these tests <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? no this is a developer experience only <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
