alamb commented on PR #6570: URL: https://github.com/apache/arrow-datafusion/pull/6570#issuecomment-1593711517
> So physical_planner will be into the same crate as physical_plan? Or a different crate? I think initially it will be in the `datafusion` (datafusion/core) crate (where it is now). We could potentially move it to its own crate in the future too (though given it is not that much code, I don't know how valuable that would be) The issue is that the planner instantiates a bunch of things defined in `datasource`; The key issue in extracting `physical_plan` from `datafusion/core` is that `datasource` is ALSO in `datafusion/core` and I can't easily take it out (b/c `TableProvider` depends directly on `SessionState`). Since the physical planner depends on `datasource` it has to stay in `datafusion/core` too, at least initailly. Once I have `physical_plan` and `datasource` detangled (so `datasource` depends on `physical_plan` but not the other way round) I can finally pull out `physical_plan` 😅 -- at least that is the hope -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
