Dandandan commented on pull request #8938: URL: https://github.com/apache/arrow/pull/8938#issuecomment-746938223
This looks great! I provided some suggestions. I think main thing that could be improved is the filter_maps + flatten that could be simplified, and could avoid allocating intermediate `Vecs` as well. I think 20% speed is worth it for more correctness and functionality for now, probably it could be recovered later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
