kou commented on code in PR #36009:
URL: https://github.com/apache/arrow/pull/36009#discussion_r1231707677
##########
format/Flight.proto:
##########
@@ -189,6 +191,31 @@ message Result {
bytes body = 1;
}
+/*
+ * The result of the CancelFlightInfo action.
+ *
+ * The result should be stored in Result.body.
+ */
+message ActionCancelFlightInfoResult {
+ enum CancelResult {
+ // The cancellation status is unknown. Servers should avoid using
+ // this value (send a NOT_FOUND error if the requested query is
+ // not known). Clients can retry the request.
+ CANCEL_RESULT_UNSPECIFIED = 0;
Review Comment:
> Sorry, what are you proposing here?
I wanted to say that how about the following (or other better name)?
```diff
index cda7dae31..5ccdd5b9a 100644
--- a/format/Flight.proto
+++ b/format/Flight.proto
@@ -196,20 +196,20 @@ message Result {
*
* This is used by CancelFLightInfoResult.result.
*/
-enum CancelResult {
+enum CancelStatus {
// The cancellation status is unknown. Servers should avoid using
// this value (send a NOT_FOUND error if the requested query is
// not known). Clients can retry the request.
- CANCEL_RESULT_UNSPECIFIED = 0;
+ CANCEL_STATUS_UNSPECIFIED = 0;
// The cancellation request is complete. Subsequent requests with
// the same payload may return CANCELLED or a NOT_FOUND error.
- CANCEL_RESULT_CANCELLED = 1;
+ CANCEL_STATUS_CANCELLED = 1;
// The cancellation request is in progress. The client may retry
// the cancellation request.
- CANCEL_RESULT_CANCELLING = 2;
+ CANCEL_STATUS_CANCELLING = 2;
// The query is not cancellable. The client should not retry the
// cancellation request.
- CANCEL_RESULT_NOT_CANCELLABLE = 3;
+ CANCEL_STATUS_NOT_CANCELLABLE = 3;
}
/*
@@ -218,7 +218,7 @@ enum CancelResult {
* The result should be stored in Result.body.
*/
message CancelFlightInfoResult {
- CancelResult result = 1;
+ CancelStatus status = 1;
}
/*
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
