rtpsw commented on PR #35902: URL: https://github.com/apache/arrow/pull/35902#issuecomment-1594150772
Because of [Weston's explanation](https://github.com/apache/arrow/pull/35902#discussion_r1221629315), I'm not sure there is a robust solution at all, at least not without significant changes to main code. The problem is that a robust test would need to ensure a break out of the loop following a call to `PauseProducing and before a call to `StopProducing`, but a test-node cannot do this robustly, because a test-node may never get control back after a call to `PauseProducing` on its input. If somehow getting control back can be ensured when `use_threads=false`, it would likely be brittle and not really a supported guarantee of Acero. Moreover, it probably can't be ensured when `use_threads=true`, and at some point in the future this will come back to haunt us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
