alamb opened a new pull request, #6697:
URL: https://github.com/apache/arrow-datafusion/pull/6697

   
   
   # Which issue does this PR close?
   
   Part of https://github.com/apache/arrow-datafusion/issues/6676
   Closes https://github.com/apache/arrow-datafusion/pull/6682
   
   # Rationale for this change
   Keeping the number of distinct test binaries down reduces disk space usage 
and decreases build time (see notes on 
https://github.com/apache/arrow-datafusion/pull/6682)
   
   This implements a modified version of @crepererum 's suggestion from 
https://github.com/apache/arrow-datafusion/pull/6682#discussion_r1232024517
   
   Instead of making a dataframe specific test binary as on 
https://github.com/apache/arrow-datafusion/pull/6682, this PR moves the two 
dataframe modules so they are run as part of the new `core_intrgation` binary
   
   Thus I estimate this PR will save about 250MB of disk space on the builder
   
   
   
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to