alamb commented on code in PR #6654:
URL: https://github.com/apache/arrow-datafusion/pull/6654#discussion_r1232397820
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -282,54 +341,64 @@ pub fn date_trunc(args: &[ColumnarValue]) ->
Result<ColumnarValue> {
Ok(match array {
ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(v, tz_opt)) => {
- let nano = (f)(*v)?;
- match granularity.as_str() {
- "minute" => {
- // trunc to minute
- let second = ScalarValue::TimestampNanosecond(
- Some(nano.unwrap() / 1_000_000_000 * 1_000_000_000),
- tz_opt.clone(),
- );
- ColumnarValue::Scalar(second)
+ _date_trunc(TimeUnit::Nanosecond, v, granularity.as_str(), f,
tz_opt)?
+ }
+ ColumnarValue::Scalar(ScalarValue::TimestampMicrosecond(v, tz_opt)) =>
{
+ _date_trunc(TimeUnit::Microsecond, v, granularity.as_str(), f,
tz_opt)?
+ }
+ ColumnarValue::Scalar(ScalarValue::TimestampMillisecond(v, tz_opt)) =>
{
+ _date_trunc(TimeUnit::Millisecond, v, granularity.as_str(), f,
tz_opt)?
+ }
+ ColumnarValue::Scalar(ScalarValue::TimestampSecond(v, tz_opt)) => {
+ _date_trunc(TimeUnit::Second, v, granularity.as_str(), f, tz_opt)?
+ }
+ ColumnarValue::Array(array) => {
Review Comment:
> For Array, should it return the values based on the input type
It should do the same as is done for the Scalar version.
My understanding is that this PR changes the Scalar version to return a type
based on the input types (not TimestampNanoSecond) so the array version should
as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
