kou commented on PR #36119: URL: https://github.com/apache/arrow/pull/36119#issuecomment-1595282936
Thanks! > We need to set the GOOGLE_CLOUD_PROJECT environment variable to some value good for testing. Alternatively, we need to expand the GCSFS configuration to accept the project id as one of the (optional) parameters and use that in the test. If specifying the project ID from API is useful for Apache Arrow users, how about choosing the alternative approach? If it's only useful for testing, the `GOOGLE_CLOUD_PROJECT` environment variable approach may be enough. > Should I send a separate PR or should we try to add these changes to this PR? Could you send a separate PR? I think that it's easier for you. If the project ID related changes don't need google-cloud-cpp 1.12.0, the separated PR don't need to update bundled google-cloud-cpp. If they need, you can cherry-pick commits from this branch and we can close this PR. It seems that there is still a static linking related problem in this PR: https://github.com/apache/arrow/actions/runs/5287582940/jobs/9568250982?pr=36119#step:5:3381 ```text rror: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...): unable to load shared object '/arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new/arrow/libs/arrow.so': /arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new/arrow/libs/arrow.so: undefined symbol: _ZN4absl12lts_2021110213cord_internal18cord_btree_enabledE ``` So I think that a PR without google-cloud-cpp update will be easy for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
