benibus commented on code in PR #36073:
URL: https://github.com/apache/arrow/pull/36073#discussion_r1232863123
##########
cpp/src/parquet/statistics.cc:
##########
@@ -277,11 +278,54 @@ template <bool is_signed>
struct CompareHelper<FLBAType, is_signed>
: public BinaryLikeCompareHelperBase<FLBAType, is_signed> {};
+struct Float16CompareHelper {
+ using T = FLBA;
+
+ static T DefaultMin() { return T{float16::max_ptr()}; }
+ static T DefaultMax() { return T{float16::min_ptr()}; }
Review Comment:
They're actually meant to be swapped like that (the impl basically treats
them as null-like values). For instance, this is the equivalent for native
floats:
https://github.com/apache/arrow/blob/5e993f9ca402199a613d7abaea163c5cd9b3dccb/cpp/src/parquet/statistics.cc#L84-L85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
