paleolimbot commented on code in PR #799:
URL: https://github.com/apache/arrow-adbc/pull/799#discussion_r1233337312


##########
c/driver/postgresql/connection.cc:
##########
@@ -185,6 +186,10 @@ class PqGetObjectsHelper {
     na_error_ = {0};
   }
 
+  static const inline std::unordered_map<std::string, std::string> 
PgTableTypes = {

Review Comment:
   Yes, sorry 😬 . There are two platforms that are not uncommon for R where 
this comes up (R 3.6 on Windows and Centos7/RHEL7 with the default compilers). 
If you really have to use C++17 it is OK; however, it does make my life a 
little easier if it can be avoided for another year or so.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to