nevi-me commented on pull request #8864: URL: https://github.com/apache/arrow/pull/8864#issuecomment-747065423
Are you building from within the `arrow` directory, or using `-p arrow`? The purpose of adding just the `cargo build` (or even `cargo check`) to CI is to prevent making changes (normally feature-gates in SIMD) that break `wasm32-unknown-unknown` targets. We have partial wasm32 support in `arrow`, in the sense that the crate can be built, but not all tests pass, and it's likely that `std::fs`-related code + some other stuff don't work. So we'd want to at least test that we don't break support, see ARROW-9088. I've just tested compiling with the wasm32 target in both Windows and Linux via WSL, and the `arrow` crate builds. I'm assuming that the 8 seconds taken is due to the build artefacts being cached from some previous build, but @jorgecarleitao would be authoritative in answering that. If you currently try to run tests without the magic sauce that's in #7767, you get: ```rust $ cargo test --target wasm32-unknown-unknown -p arrow arrow/rust/target/wasm32-unknown-unknown/debug/deps/arrow-2495d35fed1d3bb9.wasm: 1: Syntax error: end of file unexpected error: test failed, to rerun pass '--lib' ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
