qrilka commented on code in PR #6711:
URL: https://github.com/apache/arrow-datafusion/pull/6711#discussion_r1234151691
##########
datafusion/core/src/physical_plan/display.rs:
##########
@@ -192,11 +209,29 @@ impl<'a, 'b> ExecutionPlanVisitor for IndentVisitor<'a,
'b> {
}
}
-impl<'a> ToStringifiedPlan for DisplayableExecutionPlan<'a> {
- fn to_stringified(
- &self,
- plan_type: crate::logical_expr::PlanType,
- ) -> StringifiedPlan {
- StringifiedPlan::new(plan_type, self.indent().to_string())
+/// Trait for types which could have additional details when formatted in
`Verbose` mode
Review Comment:
Sure but why do you think it won't be trivial? If
https://github.com/rust-lang/rust/issues/31844 stabilized it would be much
easier of course but as far as I see, the change is tedious but should be
straitforward: just split `fmt_as` into as separate `impl`. Do I miss anything
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
