zeroshade commented on code in PR #36163:
URL: https://github.com/apache/arrow/pull/36163#discussion_r1234554181


##########
go/parquet/pqarrow/file_writer.go:
##########
@@ -181,7 +188,10 @@ func (fw *FileWriter) WriteBuffered(rec arrow.Record) 
error {
 }
 
 // Write an arrow Record Batch to the file, respecting the MaxRowGroupLength 
in the writer
-// properties to determine whether or not a new row group is created while 
writing.
+// properties to determine whether a new row group is created or not while 
writing.
+//
+// Performance-wise Write might be more favorable than WriteBuffered
+// especially if dealing with records that have a lot of rows.

Review Comment:
   Let's mention that this would be more performant in the case of a highly 
restricted memory environment, or if you have very large records with lots of 
rows, potentially close to the `max row group length`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to