pitrou commented on code in PR #36167:
URL: https://github.com/apache/arrow/pull/36167#discussion_r1234855168


##########
cpp/src/arrow/util/utf8.cc:
##########
@@ -164,5 +176,21 @@ ARROW_EXPORT Result<std::string> WideStringToUTF8(const 
std::wstring& source) {
   }
 }
 
+ARROW_EXPORT Result<std::string> UTF16StringToUTF8(const std::u16string& 
source) {

Review Comment:
   For the record, `ARROW_EXPORT` is only useful on declarations, not 
definitions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to